test(flood): add test for custom pulsetime parameter - #144
Merged
ErikBjare merged 1 commit intoJul 22, 2026
Merged
Conversation
Greptile SummaryThis PR adds coverage for the custom
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "test(flood): add test for custom pulseti..." | Re-trigger Greptile |
Contributor
Author
|
CI-green and mergeable — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #142 (which added the
pulsetimeparam toq2_flood) by adding a test that verifiesflood()respects the custompulsetimevalue.The test covers:
pulsetime=5: a 30s gap is not flooded (gap > pulsetime)pulsetime=31: a 30s gap is flooded (gap ≤ pulsetime)Originally part of #135; the code change landed in #142 but the test wasn't included.