Skip to content

test(flood): add test for custom pulsetime parameter - #144

Merged
ErikBjare merged 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:test/flood-pulsetime-coverage
Jul 22, 2026
Merged

test(flood): add test for custom pulsetime parameter#144
ErikBjare merged 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:test/flood-pulsetime-coverage

Conversation

@TimeToBuildBob

Copy link
Copy Markdown
Contributor

Follows up on #142 (which added the pulsetime param to q2_flood) by adding a test that verifies flood() respects the custom pulsetime value.

The test covers:

  • Default pulsetime=5: a 30s gap is not flooded (gap > pulsetime)
  • Custom pulsetime=31: a 30s gap is flooded (gap ≤ pulsetime)

Originally part of #135; the code change landed in #142 but the test wasn't included.

@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds coverage for the custom pulsetime argument in flood().

  • Confirms the default pulse time leaves a 30-second gap unchanged.
  • Confirms a custom 31-second pulse time fills the same gap.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • Reusing the input events is safe because each call deep-copies them before processing.

Important Files Changed

Filename Overview
tests/test_flood.py Adds a focused test for default and custom pulse-time behavior with expectations that match the implementation.

Reviews (1): Last reviewed commit: "test(flood): add test for custom pulseti..." | Re-trigger Greptile

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

CI-green and mergeable — waiting only on a maintainer click.

This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted.

@ErikBjare
ErikBjare merged commit b70e8ec into ActivityWatch:master Jul 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants