Repository navigation
test: add interrupt wait tests - #41
Merged
Merged
Conversation
`mining_check_block_and_interrupt` calls interrupt() while nothing is waiting, so it only checks that the call doesn't fail. Rename it to `mining_check_block`.
Call `waitTipChanged` and `waitNext` with no timeout, let them block in a local task, then check that `interrupt` and `interruptWait` unblock them.
Collaborator
|
ACK f3f1f8f |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
mining_wait_tip_changedandmining_block_template_lifecycletest cases to:waitTipChanged/waitNexton a local task so it is blocked until these methods return. With no timeout, it waits for actual server state changes (new tip or new template).interrupt/interruptWaitto wake the server-side wait so the local tokio task returns.This PR also removes an
interruptcall that wasn't interrupting anything.