Repository navigation
Deprecate interrupt methods and test cancellation by dropping promises - #42
Draft
xyzconstant wants to merge 3 commits into
Draft
xyzconstant wants to merge 3 commits into
xyzconstant wants to merge 3 commits into
Conversation
Collaborator
|
#41 was merged, please rebase. |
Run `waitTipChanged` and `waitNext` with no timeout on a dedicated server thread, then drop the promise. A server thread runs one call at a time, so a follow-up call intented to run on the same thread only runs once the wait has finished. With no timeout and no new tip, it can only finish by being cancelled.
Mirror bitcoin/bitcoin#36097. Long-running calls can now be stopped by dropping their promise, so explicit interrupt methods are no longer needed.
xyzconstant
force-pushed
the
ipc-cancellation-support
branch
from
September 28, 2026 15:26
d1f3778 to
060719e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on bitcoin/bitcoin#36097.
Modify the interrupt testing flow to just drop a wait promise to cancel an ongoing wait run on the server. Deprecate the interrupt methods as well, as they are no longer needed.