Skip to content

[test] make HTTP timeout checks wait for cancellation (LET-47) - #202

Merged
vt128 merged 1 commit into
masterfrom
codex/fix-http-timeout-fixture-20261110
Nov 10, 2026
Merged

vt128 merged 1 commit into
masterfrom
codex/fix-http-timeout-fixture-20261110

Conversation

@vt128

@vt128 vt128 commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

The HTTP timeout regressions let the server reply after a fixed 50 ms while expecting a 10 ms client timeout. The current macOS/Go 1.27 run returned HTTP 200 instead, failing GET Timeout. Use a dedicated test endpoint that waits for request cancellation; a three-second failure guard returns 504 if cancellation never arrives. The two original timeout cases retain their exact expected errors. All normal GET, no-timeout, TLS and other cases keep their existing endpoint and assertions.

Only lib/http/http_test.go changes. The other 175 tracked files are byte-identical to master, including all 64 production Go files, modules and directives; the interpreter pin and Go floors are unchanged. Targeted race checks run each of the two cases 20 times on both Go 1.27.3 and Go 1.19.13 (80 passing subcases). Four fresh baseline/candidate full build, race tests twice, vet and coverage comparisons pass; every production coverage block and hit state matches. The normal commit hook passes. The original failed CI log remains preserved; no old CI job was rerun to seek a pass.

Tracks LET-47 / LOCAL-050. The exact head has passed all 23 required / 24 reported checks, both Codecov gates, review inspection and checks-watch. No runtime change, performance sampling, tags, releases or auto-merge.

Use a dedicated cancellation endpoint for the two existing timeout cases,
with a three-second failure guard instead of racing a successful response.
Keep their original error assertions and all normal HTTP fixtures unchanged.

Refs LET-47, LOCAL-050.
@codacy-production

codacy-production Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 5 complexity · 0 duplication

Metric Results
Complexity 5
Duplication 0

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation (-1.00%)
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (89f06e1) 8441 8028 95.11%
Head commit (7db00ee) 8441 (+0) 8028 (+0) 95.11% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#202) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.98%. Comparing base (89f06e1) to head (7db00ee).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   93.98%   93.98%           
=======================================
  Files          53       53           
  Lines        6755     6755           
=======================================
  Hits         6349     6349           
  Misses        258      258           
  Partials      148      148           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vt128
vt128 marked this pull request as ready for review November 10, 2026 05:44
@vt128
vt128 merged commit b690efc into master Nov 10, 2026
24 checks passed
@vt128
vt128 deleted the codex/fix-http-timeout-fixture-20261110 branch November 10, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant