feat(maf): include model name in response updates - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThreadEventExtensions.ToAgentResponseUpdatenow accepts an optional model name and stamps it intoAgentResponseUpdate.AdditionalProperties["modelName"](trimmed; empty string when not configured).CodexAIAgentpasses the configuredThreadOptions.Modelthrough in both the non-streaming (RunAsync) and streaming (RunStreamingAsync) paths.AuthorNameis now always set tocodex(previously only when empty), and the redundantagentNameentry inAdditionalPropertieswas removed from all thread-event update factories.ToChatMessagefalls back to thecodexagent name when the source update has no author.Tests
ThreadEventExtensionsTestsassertions for the newAuthorName/modelNamebehavior and the removal of theagentNameproperty.ToChatMessagefalls back to the agent name when the update author is missing.Note: test execution results are not included here; the test suite was not run as part of creating this PR.