Repository navigation
Collapse long redactions on the verify page; reveal each passage once (plain-text copy) - #31
Merged
Merged
Conversation
… (plain-text copy) Verify page: a redacted stretch of 240+ hidden characters (one long run, or many fully hidden lines with revealed line breaks) shows as one row '⋯ 9,139 redacted characters (~115 lines) ⋯ show' that expands on click. CLI: the preview/verify output merges 3+ fully redacted lines the same way. CLI --reveal: in multipart/alternative mail, a passage found in the plain-text part is no longer also revealed inside the text/html part (--reveal-all-parts restores that). SKILL.md: reveal each passage once, in its most human-readable copy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (5)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review findings: (1) one plain-text regex match suppressed unrelated HTML-only matches of the same regex; (2) anything outside text/html (MIME headers, attachments) counted as the 'plain-text copy', hiding the readable HTML occurrence. Now each HTML match is skipped only if the same matched text occurs inside text/plain part content. Tests for both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Review follow-up (6553cda):
Both cases now have tests: 53/53 pass, and 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human intent
Changes
MaskedText,src/utils/maskedRuns.ts): a redacted stretch with at least 240 hidden characters collapses to one row,⋯ N redacted characters (~L lines) ⋯ show, and clicking expands it.█ ⋯ N redacted characters (L lines) ⋯.--reveal/--reveal-regex: inmultipart/alternativemail, a match in the plain-text part is no longer also revealed in thetext/htmlpart. A warning says so, and--reveal-all-partsrestores the old behaviour. Text that exists only in the HTML part is still revealed.Evidence
5db31511-…in headless Chromium: the body renders as 2 collapsed rows (9,139 and 18,169 characters) instead of about 27,000 █ characters. Expanding one restores its blocks.tests/masked-runs.test.tscovers the one-run, many-lines and short cases, CLI compaction, and reveal-once with--reveal-all-parts. Full suite 51/51;tsc -bclean;vite buildOK.🤖 Generated with Claude Code
Summary by CodeRabbit
--reveal-all-partsto show all matching copies.