Implement downloader and error handling for patch retrieval - #14
Draft
Iamliuxiaozhen wants to merge 1 commit into
Draft
Iamliuxiaozhen wants to merge 1 commit into
Iamliuxiaozhen wants to merge 1 commit into
Conversation
- Introduced `Downloader` trait and `CurlDownloader` struct in `download.rs` for fetching patches using curl. - Added `AppError` enum in `error.rs` to handle various application errors, including download failures and invalid arguments. - Created `Host` trait and platform-specific implementations for GitHub and GitLab in `host.rs`, encapsulating platform behavior. - Refactored `main.rs` to utilize the new downloader and error handling, improving code organization and readability. - Removed redundant code related to command-line argument parsing and patch downloading, centralizing functionality in dedicated modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downloadertrait andCurlDownloaderstruct indownload.rsfor fetching patches using curl.AppErrorenum inerror.rsto handle various application errors, including download failures and invalid arguments.Hosttrait and platform-specific implementations for GitHub and GitLab inhost.rs, encapsulating platform behavior.main.rsto utilize the new downloader and error handling, improving code organization and readability.