Skip to content

Changes for native spark functions #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LOGANBLUE1 wants to merge 3 commits into
base: blocking
Choose a base branch
from
Open

Changes for native spark functions #1354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
726ba3c
added final changes
LOGANBLUE1 Jul 29, 2026
a43ceb9
Removed isNative
LOGANBLUE1 Jul 29, 2026
2115c9d
-
LOGANBLUE1 Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions common/core/src/main/java/zingg/common/core/similarity/function/SimFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ public abstract class SimFunction<T> implements Serializable{ //extends UDF2<T,T

public static final Log LOG = LogFactory.getLog(SimFunction.class);
protected String name;
protected boolean isNative = false;

public int getNumFeatures() {
return 1;
Expand All @@ -37,10 +36,6 @@ public SimFunction() {
public SimFunction(String name) {
this.name = name;
}
public boolean isNative() {
return this.isNative;
}




Expand Down
6 changes: 5 additions & 1 deletion spark/core/src/main/java/zingg/spark/core/model/SparkFeatureCreators.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,16 @@ public SparkFeatureCreators(Map<FieldDefinition, Feature<DataType>> featurers, M
for (SimFunction sf : sfList) {
String outputCol = columnHelper.getColumnName(fd.fieldName, sf.getName(), count);
columnHelper.getColumnsAdded().add(outputCol);
transformers.add(new SparkTransformer(fd.fieldName, new SparkSimFunction(sf), outputCol));
transformers.add(createTransformer(sf, fd.fieldName, outputCol));
count++;
}
}
}

protected SparkTransformer createTransformer(SimFunction sf, String fieldName, String outputCol) {
return new SparkTransformer(fieldName, new SparkSimFunction(sf), outputCol);
}

public void register(SparkSession session) {
for (SparkTransformer t : transformers) {
t.register(session);
Expand Down
3 changes: 1 addition & 2 deletions spark/core/src/main/java/zingg/spark/core/model/SparkMLPipeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
import zingg.common.core.model.ModelColumnHelper;
import zingg.common.core.model.ModelGrid;
import zingg.spark.client.SparkFrame;
import zingg.spark.core.similarity.SparkTransformer;

public class SparkMLPipeline implements Serializable {

Expand All @@ -44,7 +43,7 @@ public class SparkMLPipeline implements Serializable {
private LogisticRegression lr;
private Transformer transformer;
private VectorValueExtractor vve;
protected ModelColumnHelper columnHelper;
private ModelColumnHelper columnHelper;

public SparkMLPipeline() {
}
Expand Down
Loading