Skip to content

Cagra support & update raft version - #207

Merged
sre-ci-robot merged 7 commits into
zilliztech:mainfrom
presburger:cagra
Nov 24, 2023
Merged

Cagra support & update raft version#207
sre-ci-robot merged 7 commits into
zilliztech:mainfrom
presburger:cagra

Conversation

@presburger

@presburger presburger commented Nov 22, 2023 •
edited
Loading

Copy link
Copy Markdown

/kind feature
issue: #10

@wphicks @presburger
Add CAGRA support with latest RAFT
9dbb2f0 
Update to RAFT 23.12
Update CAGRA integration to improve performance
Avoid post-filtering using RAFT's new filtering feature
Use RAFT's new device_resources_manager to simplify and optimize
resource initialization
Update build infratructure to build for all supported CUDA architectures
Refactor RAFT integration code to more cleanly separate RAFT code from
Knowhere code
Avoid exposing RAFT symbols in any Knowhere header

Signed-off-by: William Hicks <whicks@nvidia.com>
@wphicks @presburger
Fix todo items discovered during self-review
651b9a7 
Signed-off-by: William Hicks <whicks@nvidia.com>
@wphicks @presburger
Update to mainline RAFT and run linters
5ee92fb 
Signed-off-by: William Hicks <whicks@nvidia.com>
@wphicks @presburger
Add workaround for refinement issue
0f1e031 
Signed-off-by: William Hicks <whicks@nvidia.com>
@sre-ci-robot
sre-ci-robot requested a review from cydrain November 22, 2023 07:05
@sre-ci-robot

sre-ci-robot commented Nov 22, 2023

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Presburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
sre-ci-robot requested a review from hhy3 November 22, 2023 07:05
@mergify mergify Bot added the dco-passed label Nov 22, 2023
@mergify

mergify Bot commented Nov 22, 2023

Copy link
Copy Markdown

@presburger 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@presburger
presburger force-pushed the cagra branch 2 times, most recently from 8974ba7 to 3f14d2e Compare November 22, 2023 08:45
@presburger
support cagra
3f14d2e 
Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
@presburger

presburger commented Nov 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Author

/kind feature

@presburger
support cagra
adbf8e0 
Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
@presburger
support cagra
36297e8 
Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
alexanderguzhva
alexanderguzhva reviewed Nov 22, 2023
View reviewed changes
Comment thread include/knowhere/comp/index_param.h
Comment thread src/index/gpu_raft/gpu_raft_ivf_flat_config.h
Comment thread src/index/gpu_raft/gpu_raft_ivf_flat_config.h
Comment thread src/index/gpu_raft/gpu_raft_ivf_pq_config.h
Comment thread tests/ut/test_gpu_search.cc
@presburger

presburger commented Nov 23, 2023

Copy link
Copy Markdown
Author

/run-e2e

@mergify mergify Bot added ci-passed and removed ci-passed labels Nov 23, 2023
@presburger

presburger commented Nov 23, 2023

Copy link
Copy Markdown
Author

/run-e2e

1 similar comment
@presburger

presburger commented Nov 23, 2023

Copy link
Copy Markdown
Author

/run-e2e

@mergify mergify Bot added the ci-passed label Nov 23, 2023
liliu-z
liliu-z reviewed Nov 23, 2023
View reviewed changes
Comment thread src/common/raft/integration/raft_knowhere_config.hpp
@liliu-z

liliu-z commented Nov 23, 2023

Copy link
Copy Markdown
Collaborator

/lgtm

@alexanderguzhva

alexanderguzhva commented Nov 23, 2023

Copy link
Copy Markdown
Collaborator

/lgtm
given the assumption that a large topk for ivfpq will be tested and added :)

@sre-ci-robot
sre-ci-robot merged commit 7d9e553 into zilliztech:main Nov 24, 2023
@wphicks wphicks mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexanderguzhva alexanderguzhva alexanderguzhva left review comments
@liliu-z liliu-z liliu-z left review comments

Assignees

@alexanderguzhva alexanderguzhva

@liliu-z liliu-z

Labels

approved ci-passed dco-passed kind/feature lgtm size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@presburger @sre-ci-robot @liliu-z @alexanderguzhva @wphicks