Repository navigation
perf: use 4096 as default SINDI window size - #1855
Merged
sre-ci-robot merged 1 commit intoSep 28, 2026
Merged
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chasingegg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@chasingegg 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
chasingegg
force-pushed
the
codex/sindi-default-window
branch
from
September 28, 2026 05:15
554c0c5 to
95deb3a
Compare
Signed-off-by: chasingegg <gaoc96@qq.com>
chasingegg
force-pushed
the
codex/sindi-default-window
branch
from
September 28, 2026 05:17
95deb3a to
5b85be8
Compare
Collaborator
Author
|
/kind improvement |
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #1730.
Motivation
Local IP benchmarks on NQ, FEVER, HotpotQA, and MS MARCO SPLADE data measured
window sizes 1024, 4096, 16384, and 65535 at topK 10, 100, and 1000. Window
4096 had the highest QPS in every dataset/topK combination for both tested
dim_max_score_ratiovalues (1.05 and 0.756), with unchanged available recall.Window 4096 balances cache locality and per-window overhead: its 16 KiB score
buffer fits comfortably in L1 and enables finer-grained pruning and earlier
TopK threshold updates, while avoiding the extra metadata and cursor/loop work
seen with window 1024.
Query-level counters on the same workload confirm the pruning effect (ranges
across the four datasets):
SPLADE IP performance (
dim_max_score_ratio=1.05)The benchmark used the first 1,000 real queries, no filter, three timed rounds
per point (median reported), and eight search threads on an 8-core Neoverse-V2
machine. Table values are QPS; the best window in each row is bold.
All tested window sizes produced the same sampled result hash for each
dataset/topK slice, and all available recall values were unchanged.
Test plan
knowhere_teststarget from a cleanupstream/mainworktreeknowhere_tests "[config]"