Skip to content

Remove all table size config for new adapters#629

Open
puddly wants to merge 3 commits into
zigpy:devfrom
puddly:puddly/clean-up-adapter-startup
Open

Remove all table size config for new adapters#629
puddly wants to merge 3 commits into
zigpy:devfrom
puddly:puddly/clean-up-adapter-startup

Conversation

@puddly

@puddly puddly commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

I believe all of the config affecting table sizes no longer works with newer versions of EmberZNet. The source route table size, for example, is a compile-time constant that generates an array of that size in memory. There doesn't appear to be a way to grow or shrink it.

The specific EZSP version where these config options start taking effect needs to be determined, as right now we apply it for all adapters supporting EZSPv7 and above.

@codecov

codecov Bot commented Jun 13, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.15%. Comparing base (91b8f37) to head (59ff4d3).
⚠️ Report is 63 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #629   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          50       50           
  Lines        3412     3415    +3     
=======================================
+ Hits         3383     3386    +3     
  Misses         29       29           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant