Pin bundled TypeScript to v6.0.3 to fix server crash with TypeScript 7 - #134
Merged
MrSubidubi merged 1 commit intoJul 14, 2026
Merged
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @levanlinchik on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
MrSubidubi
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin the bundled TypeScript to 6.0.3 instead of installing
typescript@latest, and keep the copy next to the language server at that version unconditionally (the worktree package.json check is removed, see below).typescript@lateston npm is7.xsince July 8. That's the native Go compiler, and its npm package no longer ships the JS API (ts.server,createLanguageService, ...), so@vue/language-servercrashes at startup:TypeError: Cannot read properties of undefined (reading 'protocol')6.0.3 is the last JS-based release and it's what
vuejs/language-toolspin themselves. Volar isn't expected to work with TS 7 until the new compiler API ships (planned for 7.1).The "skip install when the project has its own typescript" check is removed because:
npm install @vue/language-serverpullstypescript@latestin as a peer dependency anyway, so a broken7.xcopy ends up in the extension dir even when we skip our own installThe version check runs on every server start, so existing broken installs self-heal: installed
7.0.2 != 6.0.3triggers a reinstall.