Skip to content

diag: dump the DACL bytes at every phase of the S6 fixture #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zayokami wants to merge 2 commits into from
Closed

diag: dump the DACL bytes at every phase of the S6 fixture #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
666e489
diag(sandbox): dump the DACL bytes at every phase of the S6 fixture
zayokami Oct 15, 2026
16933c8
diag(sandbox): dump the DACL through three reader classes and simulat…
zayokami Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/tools/src/sandbox/appcontainer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ const FILE_READ_EXECUTE = 0x0012_00a9;
* group are deliberately not asked for, because writing a DACL is this
* module's whole job and touching an owner is not.
*/
function readDacl(path: string): Uint8Array | null {
export function readDacl(path: string): Uint8Array | null {
const lib = advapi();
if (lib === null) return null;
const pathBuf = wbuf(path);
Expand Down Expand Up @@ -539,7 +539,7 @@ function readDacl(path: string): Uint8Array | null {
}

/** Every ACE in a DACL, walked by size, as raw slices. */
function acesOf(dacl: Uint8Array): Uint8Array[] {
export function acesOf(dacl: Uint8Array): Uint8Array[] {
const aces: Uint8Array[] = [];
let offset = 8; // the 8-byte ACL header
while (offset + 4 <= dacl.length) {
Expand Down Expand Up @@ -568,7 +568,7 @@ function aceSidString(ace: Uint8Array): string | null {

// Long-form design notes: docs/dev/sandbox.md
/** A new DACL holding these ACEs. `AceCount` is the number of ACEs, not the byte length. */
function buildDacl(aces: Uint8Array[]): Uint8Array {
export function buildDacl(aces: Uint8Array[]): Uint8Array {
const size = 8 + aces.reduce((sum, ace) => sum + ace.length, 0);
const dacl = new Uint8Array(size);
const view = new DataView(dacl.buffer);
Expand All @@ -584,7 +584,7 @@ function buildDacl(aces: Uint8Array[]): Uint8Array {
}

/** An ACCESS_ALLOWED_ACE granting `mask` to `sidBytes`, inherited downward. */
function allowAce(sid: Uint8Array, mask: number): Uint8Array {
export function allowAce(sid: Uint8Array, mask: number): Uint8Array {
const ace = new Uint8Array(8 + sid.length);
const view = new DataView(ace.buffer);
view.setUint8(0, 0); // ACCESS_ALLOWED_ACE_TYPE
Expand All @@ -600,7 +600,7 @@ function allowAce(sid: Uint8Array, mask: number): Uint8Array {
* 2026-10-15: a plain write to a protected directory leaves it protected. The
* protection state has its own writer below.
*/
function writeDacl(path: string, dacl: Uint8Array): string | null {
export function writeDacl(path: string, dacl: Uint8Array): string | null {
const lib = advapi();
if (lib === null) return "advapi32 is not loadable";
const code = lib.symbols.SetNamedSecurityInfoW(
Expand Down Expand Up @@ -640,7 +640,7 @@ function sdWithDacl(dacl: Uint8Array, protect: boolean): Uint8Array {
* leave a protected directory protected (measured), and a `.git` that stays
* protected after release would silently stop receiving the next grant's ACE.
*/
function writeDaclProtection(path: string, dacl: Uint8Array, protect: boolean): string | null {
export function writeDaclProtection(path: string, dacl: Uint8Array, protect: boolean): string | null {
const lib = advapi();
if (lib === null) return "advapi32 is not loadable";
if (lib.symbols.SetFileSecurityW(ptr(wbuf(path)), DACL_SECURITY_INFORMATION, ptr(sdWithDacl(dacl, protect))) !== 0) {
Expand Down
Loading
Loading