Fix: [SECURITY] Refactor os.system to subprocess.run to fix quoting issue - #10
Open
glensc wants to merge 2 commits into
Open
Fix: [SECURITY] Refactor os.system to subprocess.run to fix quoting issue#10glensc wants to merge 2 commits into
glensc wants to merge 2 commits into
Conversation
Replace the shell-based `os.system(...)` call with `subprocess.run(...)` using a list of arguments. Co-authored-by: GitHub Copilot (MAI-1.1 Flash) <copilot@github.com>
glensc
changed the title
- Wait through parent KeyboardInterrupt while the child handles SIGINT - Return the child status without killing or terminating the session Co-authored-by: OpenCode (gpt-5.6-sol) <noreply@openai.com>
glensc
force-pushed
the
os-system-refactor-only
branch
from
August 24, 2026 13:25
ce71ceb to
ffc9ffd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the shell-based
os.system(...)call withsubprocess.run(...)using a list of arguments.Fixes #8
Also, ensures the Ctrl+C behavior remains in place: