speculative: keep DFlash draft positions contiguous across mtmd vision chunks - #5
Open
wangcc57 wants to merge 3 commits into
Open
speculative: keep DFlash draft positions contiguous across mtmd vision chunks#5wangcc57 wants to merge 3 commits into
wangcc57 wants to merge 3 commits into
Conversation
Keep DFlash draft positions in the independent draft KV context's consecutive position space across multimodal mtmd chunks.
Normalize indentation in the DFlash2 mtmd position fix.
Align the draft position declaration with the surrounding code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With DFlash2 enabled, multimodal requests could fail with:
Text-only requests worked; the failure was reproducible after an image entered the prompt.
Cause
The target context and the independent DFlash context do not share the same position space around mtmd image chunks. DFlash was copying target positions into its own one-axis RoPE KV cache, so the next draft batch could start at a non-consecutive position.
Fix
Keep DFlash draft positions in the draft-local consecutive position space:
This keeps speculative decoding valid across image chunks.
Validation
Validated with production Qwen3.8-27B Q4_K_M + DFlash2 on 3x Tesla V100:
git diff --check passes.
Related: ggml-org#25144