fix(graph): finalize empty community lifecycle and batch selection - #171
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty community could stay stale after the summarizer returned without updating its lifecycle. Mark it empty only in an atomic write scoped to the same tenant and generation, after locking the node and rechecking entity memberships and child communities. Existing summaries and vectors are preserved.
A terminal empty community with a null summary is excluded from subsequent batches. Empty communities marked stale again remain eligible, as do legacy records without a status. The guarded write matches the already deployed fix; the batch-selection follow-up is new and is not deployed yet.
Validation: 32 focused community tests, regression red/green, full make lint, diff and secret checks passed. Eight synthetic selector cases executed on actual Neo4j via read-only UNWIND, without graph writes. Final independent GPT-5.5 review found no blocker, major or minor issue after resolving the initial null-summary finding.