You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I reviewed the PR and found one blocking issue: LeetcodeClient no longer exposes get_latest_submission / async_get_latest_submission, which is a public API break on main (src/leet2git/leetcode_client.py). I’d request changes to restore compatibility (or add a deprecation shim) before approving.
get_latest_submission and async_get_latest_submission are restored. They now use the typed problem-list + submissions-history APIs instead of the Cloudflare-blocked /submissions/latest/ endpoint. Added tests for the success and missing-history paths.
Validation: make format, make lint, make utest, make build.
Re-reviewed. The previous blocking concern is fully addressed — get_latest_submission / async_get_latest_submission are restored (commit 6a8174e) with a clean implementation that paginates the submission history API instead of the Cloudflare-blocked /submissions/latest/ endpoint. Five new tests cover the happy path, pagination, and all error branches.
Broader review findings:
No blocking issues.
Pydantic typed models for config, API payloads, and question DB are well-structured.
QuestionDB JSON-first storage with one-way pickle migration is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.leet2git/database.jsonwith legacy pickle migration