chore: one version for the workspace, and binaries that can say which - #23
Merged
Conversation
Prep for a release, and two things that would have made one dishonest. Every crate was version = "0.0.0". A tarball named v0.1.0 containing binaries that claim 0.0.0 is a release that disagrees with itself, so the version lives in [workspace.package] now and every crate inherits it. And none of the three binaries could say what they were. That is the first question anyone asks about a binary sitting on a machine, and until now the only answer was to check the file's hash against a tarball. `--version` on oxinit, oxctl and oxlogd. oxinit answers it *before* the PID 1 check, deliberately: the person holding a binary and wondering what it is, is exactly the person who cannot run it as PID 1 to find out. It still refuses to run as anything else — verified both ways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for cutting v0.1.0. Two things that would have made the release
dishonest.
Every crate was
version = "0.0.0". A tarball namedv0.1.0containing binaries that claim
0.0.0is a release that disagrees withitself. The version lives in
[workspace.package]now and every crateinherits it.
None of the three binaries could say what they were. That is the
first question anyone asks about a binary sitting on a machine, and the
only answer available was hashing the file against a tarball.
oxinitanswers before the PID 1 check, deliberately: the personholding a binary and wondering what it is, is exactly the person who
cannot run it as PID 1 to find out. It still refuses to run as anything
else, and both halves are verified.
The README's pre-alpha line now says the unit format may change between
any two releases, which is the thing a version number could otherwise be
read as promising against.