Skip to content

benchmarks: propagate S3 GET stream errors through byte counter #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adstep wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −7
Open

benchmarks: propagate S3 GET stream errors through byte counter #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions benchmarks/src/metrics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as fs from 'node:fs'
import { Transform } from 'node:stream'
import { Readable } from 'node:stream'
import { monitorEventLoopDelay } from 'node:perf_hooks'

/**
Expand Down Expand Up @@ -66,12 +66,13 @@ export const countS3Ops = (plugin, counters) => {
client.getObject = async (...args) => {
counters.gets++
const stream = await get(...args)
// count through a Transform rather than a 'data' listener: a listener would
// put the stream into flowing mode and race the caller's `for await`
const counting = new Transform({
transform (chunk, _enc, cb) { counters.getBytes += chunk.length; cb(null, chunk) }
})
return stream.pipe(counting)
const counted = async function * () {
for await (const chunk of stream) {
counters.getBytes += chunk.length
yield chunk
}
}
return Readable.from(counted())
}
/** @param {any[]} args */
client.removeObject = (...args) => {
Expand Down