Repository navigation
Conversation
…on Windows Copilot-Session: 57346a82-6880-4206-9552-9105be00e3e7
adstep
marked this pull request as ready for review
October 14, 2026 01:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark suite builds file paths with
new URL(..., import.meta.url).pathname. On Windows that returns/D:/..., which Node resolves toD:\D:\..., so the suite fails withENOENTwhen it writesRESULTS.mdand when it forksproc/hub.jsorproc/y-native.js.This switches the four call sites to
path.join(import.meta.dirname, ...), which gives native paths on every platform. The repo already requires Node 22+, soimport.meta.dirnameis always available.src/index.js:RESULTS.mdoutput pathsrc/cluster.js: forked hub processsrc/suites/y1-primitives.js: forked y-native processsrc/trace.js: trace file pathTesting (Windows 11, Node 26): ran y1.2, y1.7 with
useYNative: true, y2.1 against the dev databases, and y7.1 with a placeholder trace file (confirms it is found and read). All four paths now resolve correctly.npx standard benchmarks/src/passes.