Repository navigation
strip a windows drive or stream prefix in sanitize_filename - #2651
Merged
yhirose merged 1 commit intoOct 27, 2026
Merged
Conversation
On Windows a ':' ends a drive prefix or names an NTFS stream, so a multipart filename such as C:.. or C:evil.dll passed sanitize_filename unchanged. Treat ':' as a separator there; elsewhere it stays an ordinary file name character.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows drive prefix survives sanitize_filename
On Windows a ':' ends a drive prefix or starts an NTFS stream name, but
sanitize_filenameonly cuts at/and\, so an uploaded filename ofC:..orC:evil.dllcomes back unchanged: joined withstd::filesystem::pathit replaces the upload directory (a different root name wins inoperator/), and joined as a stringa:bwrites a hidden stream ofa. I've made ':' a separator on Windows only, in line withis_valid_pathafter #2643; the new test pins both platforms, though its Windows branch only runs in the Windows CI job.