fix: complex fields in local editor - #1301
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe image detection logic now separates direct images from nested image objects. Nested images are recognized only when an object contains exactly one Merge Risk: ⚪ Minimal · up to This change adjusts local editor classification for complex fields and adds focused tests; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
We assume the types of the entity fields in local data because we do not have the authoritative stream definition. We were over-classifying any object with
.imagesubfield as a Complex Image.https://yext.slack.com/archives/C0AQSEXMZ3L/p1787940880994969?thread_ts=1787936147.451099&cid=C0AQSEXMZ3L
Tested with a local pack used in the services repo
Will port over to
section-libraryafter merge