fix: decouple facet search labels from visual display - #699
Merged
Conversation
|
coverage: 84.687% (-0.04%) from 84.727% — decouple-facet-option-label-5737 into main |
Contributor
|
Current unit coverage is 89.38856015779093% |
anguyen-yext2
approved these changes
Aug 18, 2026
k-gerner
added a commit
that referenced
this pull request
Aug 18, 2026
* chore: move the signpost next to GDA header and remove default label (v3.1.1) (#682) * chore: move the signpost next to answer text and remove default label (v3.1.1) * remove unnecessary test * Update snapshots * prettier button * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v3.1.1 * feat: gda feedback buttons (#685) * add feedback buttons * rename var * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v3.2.0 * fix: invalid empty string vertical key in analytic events (v3.2.1) (#688) J=WAT-5714 TEST=manual verified GDA feedback events on test-site was valid and made it to report builder in storm * release: v3.2.1 * fix: js-yaml vulnerabilities (v3.2.2) (#694) * fix: js-yaml vulnerabilities (v3.2.2) * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v3.2.2 * revert version bump to republish (#696) * release: v3.2.2 * fix: decouple facet search labels from visual display (#699) * fix * Automated update to repo's documentation from github action * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v3.3.0 --------- Co-authored-by: anguyen-yext2 <143001514+anguyen-yext2@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Anh Thu Nguyen <anguyen@yext.com> Co-authored-by: Kyle Gerner <49618240+k-gerner@users.noreply.github.com> Co-authored-by: Kyle Gerner <kgerner@yext.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always associate searchable facet inputs with a facet-specific label,
while allowing that label to be visually shown or hidden.
showOptionsSearchInputLabelnow controls only visual presentation. Whenfalse, the label remains available to assistive technology through thesr-onlyclass. Whentrue, the label is displayed normally.Consumers can control visibility for an individual
StandardFacet,NumericalFacet, orStaticFilterscomponent:<StandardFacet showOptionsSearchInputLabel />Facetsnow also acceptsshowOptionsSearchInputLabelto control allautomatically rendered facets. Child facets can explicitly override the
parent setting.
Add
visuallyHiddenLabelsupport toSearchInputand render hidden labelsafter the input to preserve existing sibling-spacing behavior.
Addresses issue #692
J=WAT-5737