Skip to content

Fix: Phase 2 WAL dump bugs and add cache viewer - #30

Merged
akeenkarkare merged 1 commit into
mainfrom
fix/phase2-wal-dump-fix
Nov 21, 2025
Merged

Fix: Phase 2 WAL dump bugs and add cache viewer#30
akeenkarkare merged 1 commit into
mainfrom
fix/phase2-wal-dump-fix

Conversation

@akeenkarkare

@akeenkarkare akeenkarkare commented Nov 21, 2025

Copy link
Copy Markdown
Member

Summary

  • Fixed cache_manager method name bug in admin endpoint (get_stats()get_cache_stats())
  • Previously added cache viewer tab to log viewer HTML for debugging
  • Previously removed unused CACHE_FIX_PLAN.md

Changes

  • routes/admin.py: Fixed method call to use correct get_cache_stats() method name
  • static/log_viewer.html: Added cache status viewer tab with stats display
  • Removed CACHE_FIX_PLAN.md (no longer needed)

Test plan

  • Verify cache viewer loads without errors
  • Check cache statistics display correctly
  • Test WAL status display
  • Verify dirty entries tracking
  • Test manual cache dump button

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated cache statistics data retrieval to improve accuracy in admin monitoring capabilities.

✏️ Tip: You can customize this high-level summary in your review settings.

Changed get_stats() to get_cache_stats() to match CacheManager's actual method name.
This fixes the cache viewer error: 'CacheManager' object has no attribute 'get_stats'

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 21, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

The PR updates the cache statistics retrieval method in the FastAPI admin routes from cache_manager.get_stats() to cache_manager.get_cache_stats(), adjusting the data source for the cache status endpoint response.

Changes

Cohort / File(s) Summary
Cache Statistics Method Update
scripts/fastapi/routes/admin.py
Updated the method call for retrieving cache statistics in the get_cache_status endpoint from get_stats() to get_cache_stats()

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • SidmoGoesBrrr

Poem

🐰 A hop, skip, and a method call away,
The cache stats now know the right way,
From get_stats to get_cache_stats we go,
A small change that makes the endpoint glow! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/phase2-wal-dump-fix

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bcf1af4 and 030820f.

📒 Files selected for processing (1)
  • scripts/fastapi/routes/admin.py (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SidmoGoesBrrr SidmoGoesBrrr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smh

@akeenkarkare
akeenkarkare merged commit f7996c2 into main Nov 21, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants