Skip to content

fix(api): correct params for failing catalogue endpoints #42 - #53

Merged
yashiels merged 1 commit into
mainfrom
agent/endpoint-params
Sep 27, 2026
Merged

yashiels merged 1 commit into
mainfrom
agent/endpoint-params

Conversation

@yashiels

Copy link
Copy Markdown
Owner

Every change is traced to the 4.3.0 app call site and verified live (read-only):

  • config app-version: platform + app_version defaults (was 500)
  • cms page: platform=android, real slug; cms route: positional sent as link
  • account group form: named group ids (personal, ...)
  • help context: real context slug; help search: positional sent as search (+ page/page_size), --autocomplete (help search and help search autocomplete return 500 #43)
  • plus cancel/claim-discount/manage plan: app sends no extra params; the not-subscribed response (id + status + notification text) now maps to exit 4 with a clear message; anything else stays the raw API error
  • returns pickup-points: only needs an active return checkout; generic 500 is left as the raw error; returns tracking needs a real returnId
  • recommend pdp (recommend pdp: context encoding unknown, rejected locally #44): context=PLID:; recommend pdp --plid P --model K returns products live
  • --plid options reject non-positive / fractional / unsafe ids with exit 4

397 tests. Oracle signed off (2 rounds).

Closes #42
Closes #43
Closes #44

@yashiels
yashiels merged commit f9896f4 into main Sep 27, 2026
1 check passed
@yashiels
yashiels deleted the agent/endpoint-params branch September 27, 2026 00:08

@sentinel-skyner sentinel-skyner Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛡️ Sentinel review

No material issues found in this diff.

Automated review via cursorbridge:gpt-5.3-codex. Findings only — not an approval. Push new commits to re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant