Repository navigation
feat(pwa): rebuild service worker on Serwist with offline page and update flow - #130
Merged
Merged
Conversation
|
|
||
| # Generated by scripts/build-sw.mjs during `pnpm build` | ||
| public/sw.js | ||
|
|
There was a problem hiding this comment.
🛡️ Low public/sw.js is marked as generated/ignored, but this PR still modifies that file as a tracked artifact. .gitignore does not apply to already tracked files, so builds will continue to produce churn in git and can cause accidental commits of regenerated output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #129
PR2 of the Oracle-approved PWA plan (docs/pwa-plan.md).
What
Verification