Repository navigation
fix(jobs): verify application availability conservatively #11 - #12
Merged
Merged
Conversation
![sentinel-skyner[bot]](https://avatars.githubusercontent.com/u/208464438?s=60&v=4){kind=small}
yashiels
commented
Oct 2, 2026
yashiels
commented
Oct 2, 2026
yashiels
commented
Oct 2, 2026
| if isPublicApplicationIP(ip) { | ||
| return (&net.Dialer{Timeout: employerCheckTimeout}).DialContext(ctx, network, net.JoinHostPort(ip.String(), port)) | ||
| } | ||
| } |
There was a problem hiding this comment.
🛡️ Medium dialContext returns after dialing the first public DNS address, even when that dial fails. It never tries remaining A/AAAA records, so an unreachable IPv6 address or stale first record causes verification to fail despite another resolved address being reachable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
Changes
lnk job <id> --check-apply; narrow anonymous Lever/Workday verification with bounded HTTPS reads and non-public destination guards.Verification
make cipassed (vet, formatting, race tests).golangci-lint run --new-from-rev origin/main ./...: 0 new issues. Full-repo lint retains 20 pre-existing findings; Makefile falls back to go vet.GOOS=linux go vet ./...,go mod verifyand scratch build passed.actunavailable on this host, so the GitHub Actions workflow could not run locally. Its exact vet/race-test/gofmt steps passed locally; Ubuntu execution is gated by PR CI.Limits
Workday HTML and unsupported ATS destinations remain unverified. Free-text deadlines and candidate suitability require separate checks. LinkedIn Easy Apply status describes observed current metadata, not a completed submission.