docs(roadmap): mark v0 alpha banner and CLI import guard as done - #1741
Conversation
- Marks 'v0-alpha-banner' and 'cli-postinstall-guard' as done in ROADMAP_EXTRAS. - Updates LAUNCH_RUNBOOK.md checking off the v0 alpha banner.
|
There was a problem hiding this comment.
ℹ️ Both claims verify against current state — one terminology nit inline.
Reviewed changes
- v0 site Alpha banner → done —
ROADMAP_EXTRAS.v0-alpha-bannerflipped todone: trueinapps/www/lib/roadmap/config.ts, moving it from "Up next" to the Done group on the public roadmap; the matchingAlpha Banner on Live v0 Sitepre-launch item is checked off indocs/LAUNCH_RUNBOOK.md. - CLI postinstall guard → done —
ROADMAP_EXTRAS.cli-postinstall-guardflipped todone: trueinapps/www/lib/roadmap/config.ts.
Confirmed the supporting evidence: the live v0 site at arkenv.js.org shows an "ArkEnv v1 is in alpha!" banner linking to https://arkenv-v1.vercel.app/, and the CLI guard ships as a module-eval throw in packages/arkenv/src/index.ts exercised by the four-case library import guard suite in packages/arkenv/src/smoke.test.ts. Roadmap tests mock the config module, so the flips don't disturb them.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
Renames 'Add CLI postinstall guard for v0 upgrades' to 'Add CLI import guard for v0 upgrades' to match the actual shipped mechanism, and aligns Step 2.4 in LAUNCH_RUNBOOK.md.
|
@pullfrog review please |
There was a problem hiding this comment.
ℹ️ Minor suggestions only — one stale phrase inside the step you retitled.
Note: this review was written against head 97a576c9; if commits land on update_roadmap_alpha_banner after that, re-diff before acting.
Reviewed changes
- Marked the v0 site Alpha banner roadmap extra (
apps/www/lib/roadmap/config.ts) and its LAUNCH_RUNBOOK checklist item as done — verified the banner is live onarkenv.js.org. - Marked CLI import guard for v0 upgrades as done and retitled it from "postinstall guard" — accurate, since
arkenv'spackage.jsonhas nopostinstallscript; the guard lives inpackages/arkenv/src/index.ts:3and is covered by thesmoke.test.tslibrary-import-guard suite.
Both done flips render correctly (the roadmap page splits done vs open items and re-sorts extras by done), and the roadmap tests pass.
ℹ️ Nitpicks
docs/LAUNCH_RUNBOOK.md:61— the retitled step "Validate CLI Import Guard" still says "Verify thatnpm install arkenv… throws the clear runtime error". The guard fires on import, not install (no postinstall hook exists), so the bullet'snpm installwording contradicts the corrected heading.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
Aligns verification bullet to clarify that importing or requiring arkenv throws the runtime error, rather than npm install.
|
Addressed review nitpick in c70fc40: updated Step 2.4 in |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Reworded runbook Step 2.4 (
docs/LAUNCH_RUNBOOK.md) so its bullet describes the guard correctly: "importing or requiringarkenvas a library (import arkenv from "arkenv"/require("arkenv"))" throws the migration error, replacing the stale "npm install arkenv… throws" phrasing. This resolves the nitpick raised in the prior review.
Verified the new wording against the shipped mechanism — the guard is a module-eval throw at packages/arkenv/src/index.ts:3, and packages/arkenv/src/smoke.test.ts:16 covers both ESM import and CJS require. The roadmap item title and the runbook step now consistently describe an import-time guard (no postinstall hook exists).
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

Summary
ROADMAP_EXTRAS(apps/www/lib/roadmap/config.ts) and checks off the corresponding item indocs/LAUNCH_RUNBOOK.md(fulfilled by live announcement on v0 site pointing to v1 alpha docs).ROADMAP_EXTRAS(apps/www/lib/roadmap/config.ts) (fulfilled by the runtime import guard inpackages/arkenv/src/index.tsand verified viapackages/arkenv/src/smoke.test.ts).docs/LAUNCH_RUNBOOK.mdtoValidate CLI Import Guard.Verification
pnpm checkpassed cleanlypnpm --filter www test -- --runpassed (51 test suites, 202 tests)pnpm typecheckpassed