fix(www): resolve mobile layout overflow and center transmutation in automatic coercion showcase - #1740
Conversation
…automatic coercion showcase
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
ℹ️ Two minor suggestions — the new test pins markup rather than the fixed behavior, and the
@containerblock never governs on this page's geometry. Nothing blocking.
Reviewed changes This initial review covers the full PR (1 commit, 3 files): a container-query responsive degradation that swaps the Automatic coercion showcase to a single mobile "direct wire" below 28rem and restores the desktop 5-column gate layout above it, with new centered mobile carrier keyframes and synchronized dock pulses.
aurora.css— addscontainer-type/container-nameto the showcase<figure>, toggles.home-aurora__payload-wire--direct(mobile) vs gate + wires (desktop) via@containerand@media, trims.home-aurora__payload-colmin-widthto 3.5rem on mobile, adds mobile-only travel/raw/coerced keyframes and dock pulses, and extendsprefers-reduced-motionto hide carriers.declarative-showcase.tsx— per row, adds anaria-hiddensingle-track direct wire with absolutely-positioned raw/coerced carriers, keeping the existing desktop gate markup untouched.declarative-showcase.test.tsx— adds a jsdom test asserting the mobile direct-wire elements exist and carriers hold both raw and coerced values.
The mobile keyframe timings are internally consistent: the raw→coerced swap sits at the 50% midpoint keyframe, and the dock pulses align with token arrivals. The unit test passes (verified this run).
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
… container queries
|
Addressed both review items in commit 0d2d397:
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Incremental re-review of commit 0d2d397 (the delta since the prior pullfrog review of 79b3172 — an e2e test pinning the responsive degradation plus a container-query dedup):
- Removed the redundant
@media (min-width: 64rem)gate/dock overrides so@container stream-stage (min-width: 28rem)is now the single source of truth for the showcase layout, with a comment documenting the 28rem runway floor. At the page's real geometry (2-column bento, widget cell ~half-width), the container now genuinely governs: it crosses 28rem at ~1046px viewport, so the previous duplication (media query pre-empting the never-effective container query) is gone and the mobile direct wire correctly serves the 1024–1044px band that previously rendered a cramped gate. - Added a Playwright computed-style test in
apps/playwright-www/tests/responsive.test.tsassertingdisplayof.home-aurora__payload-wire--directvs.home-aurora__payload-gate/--1at 375px and 1280px — a real behavior pin, not just markup. Verified against the CSS geometry (container ~307px at 375px, ~564px at 1280px) so both assertion sets hold, and the CItest-e2ejob will run it via turbo--affected. - Clarified the jsdom unit test title to reflect it pins markup + carrier tokens rather than responsive behavior.
The dsf unit suite passes (2/2, re-run this run). Both prior review threads' concerns are now genuinely resolved; no new issues in the delta.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

Summary
Fixes layout overflow, backwards chip travel, and off-center transmutation in the Automatic coercion homepage showcase component (
apps/www/components/page/declarative-showcase.tsxandaurora.css).Root Cause
On narrow viewports (e.g. 375px mobile), the 5-column layout crushed the two traveling payload wires down to 12.3px. Because token chips are ~40–60px wide:
left: calc(100% - 2.5rem)resolved to a negative travel distance (12.3px - 40px = -27.7px), causing tokens to physically animate backwards into the left key column.translateY(-50%)left-anchored the tokens, causing the visual midpoint transition to occur late and off-center.Solution
@container stream-stage (min-width: 28rem)):< 28rem(448px), hides the desktop middle gate and split wires, rendering a direct full-width wire (.home-aurora__payload-wire--direct) with 159px of clear runway.>= 28rem(desktop), fully preserves the 5-column schema gate layout.transform: translate(-50%, -50%), centering each token horizontally and vertically.15%, crosses the exact midpoint at50%(where quotes dissolve and token ignites in cyan--color-accent), and docks cleanly at82%.cubic-bezier(0.2, 0.8, 0.25, 1)easing.numberandboolean) upon token arrival.prefers-reduced-motion: reduceis active.declarative-showcase.test.tsxasserting mobile single-wire direct elements and carrier values.Verification
pnpm test apps/www/components/page/declarative-showcase.test.tsx: 2/2 passedpnpm check: 0 errorspnpm typecheck: 30/30 tasks successful, 104 static pages generated