docs(www): link homepage announcement badge to v1 alpha docs - #1738
Conversation
|
53a3209 to
352cd8f
Compare
There was a problem hiding this comment.
ℹ️ No critical issues — one minor rough edge inline.
Reviewed changes — Reviewed PR #1738 (docs(www): link homepage announcement badge to v1 alpha docs) at head 352cd8f7 (1 file, 1 commit).
- Homepage announcement retarget — The homepage
AnnouncementBadgetext changes toArkEnv v1 is in alpha!and its href points to the external v1 alpha docs athttps://arkenv-v1.vercel.app/, matching the README callout. Verified the target is live,isExternalUrlcorrectly drives the<ArrowUpRight>external-link icon, and no tests or internal references depend on the removed "Presets" badge.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — Reviewed the incremental delta of PR #1738 since the prior Pullfrog review at 352cd8f7 (1 new file, 1 new commit).
- New-tab fix for external announcement badge —
AnnouncementBadge(apps/www/components/announcement-badge.tsx) now computesisExternal = isExternalUrl(href)once and setstarget="_blank"+rel="noopener noreferrer"for external hrefs, while internal links (relative paths,arkenv.js.org,localhost) keep default same-tab behavior. This directly resolves the prior review's external-link UX rough edge, and the new-tab behavior now matches the auto-detected<ArrowUpRight>icon.isExternalUrlcorrectly classifieshttps://arkenv-v1.vercel.app/as external; no otherAnnouncementBadgeusages exist, so the behavior change is fully contained.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

Summary
Updates the homepage announcement badge on arkenv.js.org to link to the new ArkEnv v1 alpha documentation at https://arkenv-v1.vercel.app/, consistent with the README announcement callout.
AnnouncementBadgecomponent with thenewprophttps://arkenv-v1.vercel.app/(renders external link arrow icon automatically)ArkEnv v1 is in alpha!Verification
pnpm checkpassedpnpm --filter www testpassedpnpm typecheckpassed