Skip to content

docs(www): link homepage announcement badge to v1 alpha docs - #1738

Merged
yamcodes merged 2 commits into
devfrom
add_arkenv_announcement_banner
Sep 2, 2026
Merged

docs(www): link homepage announcement badge to v1 alpha docs#1738
yamcodes merged 2 commits into
devfrom
add_arkenv_announcement_banner

Conversation

@yamcodes

@yamcodes yamcodes commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Summary

Updates the homepage announcement badge on arkenv.js.org to link to the new ArkEnv v1 alpha documentation at https://arkenv-v1.vercel.app/, consistent with the README announcement callout.

  • Uses existing AnnouncementBadge component with the new prop
  • Points href to https://arkenv-v1.vercel.app/ (renders external link arrow icon automatically)
  • Sets copy to ArkEnv v1 is in alpha!

Verification

  • pnpm check passed
  • pnpm --filter www test passed
  • pnpm typecheck passed

@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b5a9554

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the www Improvements or additions to arkenv.js.org label Sep 2, 2026
@yamcodes yamcodes added the preview Opt-in gate for PR preview deployments label Sep 2, 2026
@yamcodes
yamcodes force-pushed the add_arkenv_announcement_banner branch from 53a3209 to 352cd8f Compare September 2, 2026 15:03

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — one minor rough edge inline.

Reviewed changes — Reviewed PR #1738 (docs(www): link homepage announcement badge to v1 alpha docs) at head 352cd8f7 (1 file, 1 commit).

  • Homepage announcement retarget — The homepage AnnouncementBadge text changes to ArkEnv v1 is in alpha! and its href points to the external v1 alpha docs at https://arkenv-v1.vercel.app/, matching the README callout. Verified the target is live, isExternalUrl correctly drives the <ArrowUpRight> external-link icon, and no tests or internal references depend on the removed "Presets" badge.

Pullfrog  | Fix all ➔Fix 👍s ➔View workflow run | Using DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

Comment thread apps/www/app/(home)/page.tsx
@arkenv-bot

arkenv-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (Asia/Almaty)
arkenv Ready Ready Preview, Comment Sep 2 2026, 8:12 PM (Asia/Almaty)

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — Reviewed the incremental delta of PR #1738 since the prior Pullfrog review at 352cd8f7 (1 new file, 1 new commit).

  • New-tab fix for external announcement badgeAnnouncementBadge (apps/www/components/announcement-badge.tsx) now computes isExternal = isExternalUrl(href) once and sets target="_blank" + rel="noopener noreferrer" for external hrefs, while internal links (relative paths, arkenv.js.org, localhost) keep default same-tab behavior. This directly resolves the prior review's external-link UX rough edge, and the new-tab behavior now matches the auto-detected <ArrowUpRight> icon. isExternalUrl correctly classifies https://arkenv-v1.vercel.app/ as external; no other AnnouncementBadge usages exist, so the behavior change is fully contained.

Pullfrog  | View workflow run | Using DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

@yamcodes
yamcodes merged commit 13da812 into dev Sep 2, 2026
17 checks passed
@yamcodes
yamcodes deleted the add_arkenv_announcement_banner branch September 2, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Opt-in gate for PR preview deployments www Improvements or additions to arkenv.js.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant