Skip to content

test: guard social-card copy against audit drift - #1224

Merged
yakew7 merged 1 commit into
yakew7:mainfrom
dxnnystyles:test/1198-og-card-consistency
Oct 29, 2026
Merged

yakew7 merged 1 commit into
yakew7:mainfrom
dxnnystyles:test/1198-og-card-consistency

Conversation

@dxnnystyles

Copy link
Copy Markdown
Contributor

Summary

removes the hard-coded domain enumeration from the home social-card copy and adds a regression test checking benchmark-card counts against the repository's audit folders, strategy definitions, and model families. regenerates the affected home-card images so the published previews match the updated copy.

Type

  • Audit
  • Explainer
  • Bug fix
  • Other

Audit checklist

N/A — no fairness audit added or changed.

Explainer checklist

N/A — no explainer added or changed.

Linked issue

Closes #1198

Verification

  • Focused OG consistency and image-generation tests: 11 passed.
  • make test-fast: 1,219 passed, 33 skipped, 27 deselected.
  • make lint: passed.
  • Generated-file check: passed; both home-card images are present, non-empty, and 1200×630. The check does not compare PNG pixels across platforms.
  • Regenerated and visually inspected exactly assets/og/home.png and assets/og-light/home.png; their copy matches the updated source, with no clipping observed. The other 232 OG images were unchanged.
  • git diff --check: passed.

@vercel

vercel Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

@dxnnystyles is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

@yakew7 @ahmdkaml @propcgamer20-png - new PR touching a path you own, please review.

@yakew7
yakew7 merged commit 458178b into yakew7:main Oct 29, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The benchmark OG card and the home card hard-code counts and domains that are also kept elsewhere

2 participants