Repository navigation
Check that each audit's dataset link agrees between the README and its scripts - #1215
Merged
yakew7 merged 1 commit intoOct 28, 2026
Merged
Conversation
…s scripts Signed-off-by: minutechreview <141821420+minutechreview@users.noreply.github.com>
minutechreview
requested review from
ahmdkaml,
propcgamer20-png and
yakew7
as code owners
October 28, 2026 06:24
Contributor
|
@minutechreview is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@yakew7 @propcgamer20-png @ahmdkaml - new PR touching a path you own, please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
scripts/check_dataset_sources.py, which fails when a dataset link in an audit'sunfair.pyorfair.pycomments is not the link on that audit's**Dataset:**line in the README.Type
What it does
### NN · <Audit folder> - ...block in the README and takes the URLs on its**Dataset:**line.#comment of that folder'sunfair.pyandfair.py.fair.py, both Tenant Screening scripts, COMPAS and AI Fair Recruitment have none today). Trailing/and.are ignored.Wired in:
make lintruns it aftercheck_traction.py.tests/test_check_dataset_sources.pyhas 8 cases on temp repos plustest_repository_links_agreeon the real files, so the normal test run enforces it.make lintline in CONTRIBUTING mentions it.I did not add it to
.github/workflows/lint.yml: my token cannot push workflow changes. The pytest case covers it in CI meanwhile.How I checked it
python3 scripts/check_dataset_sources.pyon main: passes.unfair.pyonly: fails, namesGerman Credit Lending/unfair.pyand both URLs.unfair.pyandfair.py.pytest tests/test_check_dataset_sources.py: 9 passed.ruff checkandcheck_em_dash.pyclean,check_broken_links.pyOK.pytest --ignore=tests/browser: 1039 passed. The same 11 tests fail on main and on this branch on my machine (box DNS answers.invalid, and sometest_cli.py/ JS parity cases), so they are not from this change.Linked issue
Closes #1208