Skip to content

fix(typography): announce localized font result counts - #495

Open
Vamsi-2581 wants to merge 4 commits into
yakew7:mainfrom
Vamsi-2581:fix/font-count-announcement-487
Open

Vamsi-2581 wants to merge 4 commits into
yakew7:mainfrom
Vamsi-2581:fix/font-count-announcement-487

Conversation

@Vamsi-2581

@Vamsi-2581 Vamsi-2581 commented Oct 30, 2026 •

Copy link
Copy Markdown

Summary

Adds a polite, debounced live announcement for the filtered Google Fonts count and translates its singular/plural forms in English, Spanish, French, and Hindi.

Closes #487

Screenshots

No visual layout change. The visible count remains in place; the additional announcement is screen-reader-only.

Checklist

  • pnpm typecheck, pnpm test, pnpm lint, pnpm check:dashes and pnpm build pass
  • Conventional commit messages (feat:, fix:, docs:, chore:)
  • Tested in dark and light themes and at mobile width (375 px)
  • Works with keyboard only
  • No any, no console.log, no new external services
  • Docs and CHANGELOG.md updated if behavior changed (no usage or visual guidance changes required)

Breaking changes

None.

Testing completed

Added a Playwright check that searches for a font and reads the settled live announcement, plus unit assertions for singular and plural messages in all four locales. I could not run the repository's pnpm commands in this GitHub-only session; CI should run them on the PR branch.

Follow-up: commit b17e25d fixes a missing comma in the Hindi message catalog that prevented TypeScript parsing. No workflow jobs have run on the current head. The Vercel status reports “Authorization required to deploy.” The listed typecheck, tests, lint, dash check, build, theme/mobile, and keyboard checks remain pending.

@Vamsi-2581
Vamsi-2581 requested a review from yakew7 as a code owner October 30, 2026 13:31
@vercel

vercel Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@Vamsi-2581 is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

Hi @Vamsi-2581, welcome to DesignHub and thanks for your first pull request! 🎉

DesignHub is an open-source, local-first design and brand toolkit that runs entirely in the browser: set up a brand once and get logo variants, mockups, social media assets, a brand guidelines PDF and design tokens, plus typography, color, icon, background, effects, SVG and accessibility tools. No login, no backend, no API keys.

A maintainer will review this soon. Meanwhile, please check that pnpm typecheck && pnpm lint && pnpm format:check && pnpm build pass and that the PR template checklist is filled in.

If you like the project, a ⭐ on the repository helps other people find it.

Feel free to contribute more! Issues labeled good first issue and help wanted come with step-by-step instructions, and CONTRIBUTING.md has the setup and style guide. Questions are always welcome in the comments.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Font browser: tell screen readers the result count and the position

1 participant