Repository navigation
chore(lint): fix the last warning and fail lint on any warning - #458
Merged
Merged
Conversation
Signed-off-by: minutechreview <141821420+minutechreview@users.noreply.github.com>
Contributor
|
@minutechreview is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #441
pnpm lintended with one warning, from theimport()type annotation inlib/color/matrix.test.ts. This fixes it and makes any warning fail lint.lib/color/matrix.test.ts:import type * as ColorModuleandimportOriginal<typeof ColorModule>()instead of the inlineimport()type.package.json:lintis noweslint . --max-warnings 0.lint.ymlalready runspnpm lint, so the workflow fails on a warning without being edited.CONTRIBUTING.md: thepnpm lintrow says a warning fails it.How I checked it:
pnpm lintprints no warnings and exits 0.import()annotation back makespnpm lintexit 1 with "ESLint found too many warnings (maximum: 0)".pnpm typecheck && pnpm test && pnpm lint && pnpm format:check && pnpm check:dashes && pnpm buildpasses (133 test files, 2692 tests).