Skip to content

FDMNES additions for 2026.2.0 - #18

Merged
newville merged 52 commits into
xraypy:mainfrom
maurov:dev_2026_2
Aug 28, 2026
Merged

newville merged 52 commits into
xraypy:mainfrom
maurov:dev_2026_2

Conversation

@maurov

@maurov maurov commented Aug 28, 2026

Copy link
Copy Markdown
Member

@newville this is my work mainly related to FDMNES I did few months ago for the ASTER'X 2026 school. I think it is safe to merge and release 2026.2.0.

@maurov
maurov requested a review from newville August 28, 2026 13:59
@maurov maurov added this to the 2026.2.x milestone Aug 28, 2026

@newville newville left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. I think this will be very useful.

An example Jupyter notebook, including use of py3Dmol would be great.

Do you think it is worth adding 'run FDMNES and read results' to Larix? Maybe those could be separate functions if the calculation takes more than a few minutes, but still, it might be helpful.

@newville
newville merged commit f1374d7 into xraypy:main Aug 28, 2026
4 checks passed
@newville

Copy link
Copy Markdown
Member

@maurov Would you like me to update the date in the CHANGLELOG and push a release?

@maurov

maurov commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

@newville thanks for merging this

looks great. I think this will be very useful.

An example Jupyter notebook, including use of py3Dmol would be great.

I think this is already shown in the notebook example for FDMNES.

Do you think it is worth adding 'run FDMNES and read results' to Larix? Maybe those could be separate functions if the calculation takes more than a few minutes, but still, it might be helpful.

I am not in favor of adding this to Larch. We have developed a side project, called melezia which is doing the whole workflow of optimizing FDMNES simulations with respect to experimental data. The workflow with respect to Larch and Larixite look like the following:

image

This project will be public soon.

@maurov Would you like me to update the date in the CHANGLELOG and push a release?

Yes, please, feel free to release 2026.2.0

@maurov
maurov deleted the dev_2026_2 branch August 31, 2026 11:36
@newville

newville commented Sep 1, 2026

Copy link
Copy Markdown
Member

@maurov Thanks. I'm okay with that view. Still it would be nice to get these tools more readily available for users. Would it be reasonable to have the Larch/Larix full installer also install Melezia, maybe "at some point"?

Unfortunately, py3Dmol doesn't seem to work well for me, at least on MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants