Skip to content

test: isolated upstream reconciliation for workflow draft recovery (#14897) - #41

Closed
xmarre wants to merge 2 commits into
mirror/pr-14897-base-20261019from
mirror/pr-14897-reconcile-20261019
Closed

xmarre wants to merge 2 commits into
mirror/pr-14897-base-20261019from
mirror/pr-14897-reconcile-20261019

Conversation

@xmarre

@xmarre xmarre commented Oct 19, 2026

Copy link
Copy Markdown
Owner

Isolated mirror of Comfy-Org#14897 against upstream main 90891050cf32b6d80c440fe6c408c3e49cfe8048.

Integrates Comfy-Org#21069 workflow unload node-history cleanup, Comfy-Org#20903 queued workflow reload + canvas change capture, and Comfy-Org#21194 folder-deep-link startup without suppressing Comfy-Org#14897's paused persistence, recovery, or viewport semantics. Includes folder-loader mock reset for independent test execution.

Original PR is untouched until verification. Candidate: b3ce28a09b4dbd70503ea51601e9a09bfdfd7de6. Existing head backup: checkpoint/pr-14897-pre-upstream-20261019.

Compose upstream node history teardown, reload scheduling, and URL folder
startup behavior with draft recovery and paused startup persistence.

Co-authored-by: bymyself <cbyrne@comfy.org>
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: xmarre/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 81aae29a-0b3e-45c9-8462-1abfe1974f48
📥 Commits

Reviewing files that changed from the base of the PR and between 9089105 and aeba053.

📒 Files selected for processing: 17
  • browser_tests/tests/workflowPersistenceRecovery.spec.ts
  • src/platform/workflow/core/services/workflowService.test.ts
  • src/platform/workflow/core/services/workflowService.ts
  • src/platform/workflow/management/stores/comfyWorkflow.ts
  • src/platform/workflow/management/stores/workflowStore.persistence.test.ts
  • src/platform/workflow/persistence/base/draftTypes.ts
  • src/platform/workflow/persistence/base/storageIO.test.ts
  • src/platform/workflow/persistence/base/storageIO.ts
  • src/platform/workflow/persistence/base/workflowViewState.test.ts
  • src/platform/workflow/persistence/base/workflowViewState.ts
  • src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts
  • src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.ts
  • src/platform/workflow/persistence/stores/workflowDraftStoreV2.persistenceControl.test.ts
  • src/platform/workflow/persistence/stores/workflowDraftStoreV2.quotaSafety.test.ts
  • src/platform/workflow/persistence/stores/workflowDraftStoreV2.rollbackSafety.test.ts
  • src/platform/workflow/persistence/stores/workflowDraftStoreV2.test.ts
  • src/platform/workflow/persistence/stores/workflowDraftStoreV2.ts
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| The object-oriented model makes it easy to build up programs by accretion. What this often means, in practice, is that it provides a structured way to write spaghetti code. - Paul Graham |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

xmarre commented Oct 19, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

Please review the upstream reconciliation in this isolated mirror, particularly the Comfy-Org#20903 workflow reload sequencing, Comfy-Org#21069 unload cleanup, and Comfy-Org#21194 folder-link startup composition with paused persistence and draft recovery. The original upstream PR Comfy-Org#14897 is intentionally unchanged until verification.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Head commit changed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

xmarre commented Oct 19, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

Mirror head is now aeba0539c438b7acfc6bd36704fb0d096413fdb8 following a test-only import repair; please review this head. Original Comfy-Org PR Comfy-Org#14897 remains untouched pending CI.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Pull request base or head changed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant