Skip to content

Private key shown in loggings #14

Description

@DeveloperAnonymous

Hello!

Well, I know there is clearly ways to work around this, but it's not really safe in my opinion to print out the private key in the logs.

I know. I can change the logging level to something higher than info for the module, but I just don't think, in any cases, the key should be printed in any type of loggings (maybe debug)

Talking about debug. I don't think a query should be logged at the "info" level but the "debug"
INFO:pyxivapi.client:200 from https://xivapi.com/search?language=en&private_key=

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions