Repository navigation
fix(browser): Cmd+F finds in the page of a browser column - #138
Merged
Merged
Conversation
A page that leaves Cmd+F unhandled hands it back (WebKit resends the key) to Edit > Find in Terminal, which only acted on terminals: nothing happened in a browser column. Edit > Find... now opens a find bar on the focused browser column too, and the find items are disabled where no column can search. The terminal's find bar becomes FindBar, shared by both, with a match counter. On a page, WebPageFind drives WebKit's own find, Safari's: every match highlighted, "N matches" counted, and the public find as a fallback when WebKit lacks the private calls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LACxW892La2aFCJVsUzCoX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
⌘F did nothing in a browser column: the page handed it on to Edit > Find in Terminal, which only acted on terminals.
How
TerminalFindBarbecomes the sharedFindBar(field, ↑/↓, counter, Esc from the field); on a page ↓ is next.WebPageFinddrives WebKit's own find (private_findString+ find delegate), highlighting every match with a "N matches" counter (WebKit's match index drifts as you type, so no "i of N"); publicfindfallback without a count./code-reviewwas replaced by an independent agent review, at the user's request.🤖 Generated with Claude Code
https://claude.ai/code/session_01LACxW892La2aFCJVsUzCoX