Repository navigation
fix(ecs): synchronize inherited styles and design variable bindings - #391
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing a group's paint, moving a subtree, or switching a bound theme could leave descendants rendering their previous styles. Clearing a child's override also disagreed with a fresh document load. Resolve inherited presentation at the API update boundary against the completed scene, including unchanged descendants, while retaining authored overrides and keeping inherited values out of child documents/history.
Text design variables now resolve consistently on load and update. Removing numeric definitions restores component defaults instead of retaining stale measurements or writing NaN. This also restores rough fills during ECS geometry rebuilds, which were still passing the removed legacy
fillfield.Validation:
api.batchisolation cases failed because their fake entities did not implement ECS writes. Updated that suite's component-write mock and reran all 3 cases successfully, without changing production code. All 64 new tests passed in the full run.Next coverage batch remains rough-shape parameters and 3D geometry/material/light property synchronization.