Repository navigation
fix(ecs): close stale crop sessions and restore cancelled hover - #389
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching tools during crop left the mask in temporary soft-clipping/locked state. Empty or deleted crop targets could also throw or leave the canvas stuck in crop mode. Crop now finishes on tool changes and safely clears invalid targets. Mouse/pen hover also recovers after pointer cancellation while stale drag events remain ignored.
Add 57 real ECS event regressions for vector editing, crop sessions and nested selection. These cover reversible vertex/curve/handle/midpoint edits, interruption and external document updates, handle coupling, topology edits, nested transforms and canvas isolation. The shared event driver gains a deterministic double-click helper.
Add independent coverage gates for Select and RenderTransformer. All ECS source files remain included, and existing thresholds remain unchanged. Document the batch results and next priorities in
docs/ecs-test-coverage.md. Include an ECS patch changeset; package publication is deferred.Validation: