Repository navigation
fix(ecs): synchronize text layout and icon property changes - #388
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text edits could change the document without updating ECS layout: enabling
wordWrap, settingmaxLines, or changingtextOverflowleft the previous rendered layout in place. Clearing font properties could retain old values or produceNaN. Synchronize these fields and their defaults, deserialize overflow/leading, and treat complete document snapshots as authoritative for text anchors.Icon updates now recover from unresolved names, remove obsolete child stroke layers, and refresh ellipse raster placeholders when only the filter changes. Clearing a filter removes its component immediately.
Add 51 behavioral tests using the real ECS world, public edit/history APIs, explicit frames, actual text metrics, and registered SVG primitives. They compare component state, measured lines, child geometry and paint across edits, reloads, undo and redo. Only the GPU device/render systems are replaced. Add an
ElementsChangecoverage gate and update the incremental coverage plan.Validation:
git diff --checkpassed.Coverage compared with merged PR #387, with all ECS source files still included:
These are local full-suite figures. Browser tests are not included in Jest coverage; Coveralls master updates after merge and CI. Includes an ECS patch changeset; no package release.