Repository navigation
chore: bump undici, body-parser and qs to patched versions - #59
Merged
Merged
Conversation
undici 7.30.1 fixes GHSA-xjj6-f33q-929c (dev, via @yao-pkg/pkg-fetch). body-parser 1.20.9 fixes GHSA-27r3-jxmh-p828 and qs 6.16.2 fixes GHSA-6pq8-jhm2-2vcw, both under express. Lockfile only: every fix fits the declared ranges. npm update also takes the other in-range bumps, among them @yao-pkg/pkg 6.25.0, which builds the binaries on Node 26.12.1 instead of 26.5.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Dependabot alert 274, high: undici before 7.30.1 throws an unhandled error when a response stacks too many content-encodings (GHSA-xjj6-f33q-929c). It's a dev dependency, pulled in by
@yao-pkg/pkg-fetchto download the Node base binaries.npm auditalso flags two production dependencies under express 4.22.3 that Dependabot hasn't raised yet:qs.stringifywitharrayFormat: 'comma'throws on array elements with a non-callabletoString(GHSA-6pq8-jhm2-2vcw). Fixed in 6.16.1; the lockfile now has 6.16.2.All three fixes fit the ranges already declared, so
package.jsonis untouched and this is justnpm updateon the lockfile. That also pulls in the other in-range updates, mostly@yao-pkg/pkg6.22.0 to 6.25.0 andnpm-run-all29.0.4, and that's where most of the lockfile diff comes from.The pkg bump does change the release binaries: they now build on Node 26.12.1 instead of 26.5.1.
npm audit --omit=dev: 0 vulnerabilitiesnpm test(222 pass, 2 skipped) andnpm run lintpassnpm run buildtargets build from an emptyPKG_CACHE_PATH, so the base binaries really went through the new undici. The win-x64 binary starts and prints its help.--helpminimatch before 11.0.1 (moderate, GHSA-g3hv-75wg-m249) is still flagged. It comes in through eslint 8 and its plugins, and fixing it needs eslint 9+ with a flat config, so it's not in here.