Skip to content

chore: bump undici, body-parser and qs to patched versions - #59

Merged
xiaodoudou merged 1 commit into
masterfrom
fix/undici-7.30.1
Nov 10, 2026
Merged

xiaodoudou merged 1 commit into
masterfrom
fix/undici-7.30.1

Conversation

@xiaodoudou

Copy link
Copy Markdown
Owner

Closes Dependabot alert 274, high: undici before 7.30.1 throws an unhandled error when a response stacks too many content-encodings (GHSA-xjj6-f33q-929c). It's a dev dependency, pulled in by @yao-pkg/pkg-fetch to download the Node base binaries.

npm audit also flags two production dependencies under express 4.22.3 that Dependabot hasn't raised yet:

  • body-parser 1.20.8, high: trailing bytes after a compressed request body cause a denial of service (GHSA-27r3-jxmh-p828). Fixed in 1.20.9.
  • qs 6.16.0, moderate: qs.stringify with arrayFormat: 'comma' throws on array elements with a non-callable toString (GHSA-6pq8-jhm2-2vcw). Fixed in 6.16.1; the lockfile now has 6.16.2.

All three fixes fit the ranges already declared, so package.json is untouched and this is just npm update on the lockfile. That also pulls in the other in-range updates, mostly @yao-pkg/pkg 6.22.0 to 6.25.0 and npm-run-all2 9.0.4, and that's where most of the lockfile diff comes from.

The pkg bump does change the release binaries: they now build on Node 26.12.1 instead of 26.5.1.

  • npm audit --omit=dev: 0 vulnerabilities
  • npm test (222 pass, 2 skipped) and npm run lint pass
  • the four npm run build targets build from an empty PKG_CACHE_PATH, so the base binaries really went through the new undici. The win-x64 binary starts and prints its help.
  • not run: the Docker image build, or the binaries past --help

minimatch before 11.0.1 (moderate, GHSA-g3hv-75wg-m249) is still flagged. It comes in through eslint 8 and its plugins, and fixing it needs eslint 9+ with a flat config, so it's not in here.

undici 7.30.1 fixes GHSA-xjj6-f33q-929c (dev, via @yao-pkg/pkg-fetch).
body-parser 1.20.9 fixes GHSA-27r3-jxmh-p828 and qs 6.16.2 fixes
GHSA-6pq8-jhm2-2vcw, both under express.

Lockfile only: every fix fits the declared ranges. npm update also takes
the other in-range bumps, among them @yao-pkg/pkg 6.25.0, which builds
the binaries on Node 26.12.1 instead of 26.5.1.
@xiaodoudou
xiaodoudou merged commit a04df21 into master Nov 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant