Skip to content

chore: replace npm-run-all with npm-run-all2 - #57

Merged
xiaodoudou merged 1 commit into
masterfrom
chore/npm-run-all2
Oct 18, 2026
Merged

xiaodoudou merged 1 commit into
masterfrom
chore/npm-run-all2

Conversation

@xiaodoudou

Copy link
Copy Markdown
Owner

Closes Dependabot alert 272, critical: shell-quote before 1.11.0 lets a crafted token through quote() as a command.

It came in through npm-run-all, which has had no release since 2018. npm-run-all2 is the maintained fork. It has the same run-s command, so the build and docker scripts are unchanged, and it brings shell-quote 1.12.0. The lockfile loses about 300 lines of old transitive dependencies.

It is a devDependency, so the binaries and images do not change.

  • npm audit, dev dependencies included: 0 vulnerabilities
  • npm test and npm run lint pass
  • npm-run-all2 needs Node 22.22.2+, 24.15+ or 26, which CI's 22.x, 24.x and 26.x already are. Only someone building with an older 22.x would notice.

npm-run-all has had no release since 2018 and pulls in shell-quote 1.10.0, whose quote() lets a crafted token through as a command (Dependabot alert 272, critical). npm-run-all2 is the maintained fork, with the same run-s command, and brings shell-quote 1.12.0.

It is a devDependency used only by the build and docker scripts, so nothing that ships changes. npm audit, dev dependencies included, now finds nothing.
@xiaodoudou
xiaodoudou merged commit 096e8c7 into master Oct 18, 2026
7 checks passed
@xiaodoudou
xiaodoudou deleted the chore/npm-run-all2 branch October 18, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant