Repository navigation
chore: replace npm-run-all with npm-run-all2 - #57
Merged
Merged
Conversation
npm-run-all has had no release since 2018 and pulls in shell-quote 1.10.0, whose quote() lets a crafted token through as a command (Dependabot alert 272, critical). npm-run-all2 is the maintained fork, with the same run-s command, and brings shell-quote 1.12.0. It is a devDependency used only by the build and docker scripts, so nothing that ships changes. npm audit, dev dependencies included, now finds nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Dependabot alert 272, critical:
shell-quotebefore 1.11.0 lets a crafted token throughquote()as a command.It came in through
npm-run-all, which has had no release since 2018.npm-run-all2is the maintained fork. It has the samerun-scommand, so thebuildanddockerscripts are unchanged, and it bringsshell-quote1.12.0. The lockfile loses about 300 lines of old transitive dependencies.It is a devDependency, so the binaries and images do not change.
npm audit, dev dependencies included: 0 vulnerabilitiesnpm testandnpm run lintpass