Preserve isearch match data when expanding fragments - #827
Merged
Merged
Conversation
Owner
|
Thanks for the improvement. Mind rebasing on to main? |
Gleek
force-pushed
the
fix/restart-preserve-window
branch
from
September 20, 2026 14:18
91e5cd6 to
8225b92
Compare
Contributor
Author
done |
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running isearch sometimes I get this backtrace:
isearch-filter-predicatemust preserve match data. Expanding a fragment calls helpers that can run another search (probably some regex matching code in markdown renderer) which overrides the original match-data. Wrapping the whole thing in save-match-data restores the original match data so isearch is happy.Single line change, best viewed without whitespace: https://github.com/xenodium/agent-shell/pull/827/changes?w=1
Checklist
M-x checkdocandM-x byte-compile-file.