Apply chown before chmod in syncfileclient permission handling - #263
Merged
Conversation
chown() clears the setuid bit of a file on Linux (and its setgid bit, if the file is group-executable), even when run by root and even when the owner/group are unchanged. Since the owner/group chown ran after the permissions chmod, any syncfiles entry combining owner=/group= with a setuid/setgid permissions= value silently lost the special bits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chown() clears the setuid bit of a file on Linux (and its setgid bit, if the file is group-executable), even when run by root and even when the owner/group are unchanged. Since the owner/group chown ran after the permissions chmod, any syncfiles entry combining
owner=/group=with a setuid/setgidpermissions=value silently lost the special bits.E.g.:
Would set 0755 instead.
works.