Repository navigation
fix(platform): Windows 64-bit file I/O and MinGW build fixes - #59
Merged
Merged
Conversation
danielsreichenbach
commented
Oct 3, 2026
danielsreichenbach
commented
Member
- Fix fseek/ftell/mktime to use 64-bit variants on Windows (files >2GB, dates post-2038)
- Only link ucrt on MSVC, not MinGW (MinGW uses msvcrt.dll)
- Single bounds check for instruction fetch in VM hot loop
C is 32-bit on Windows, so standard fseek/ftell can't handle files >2GB. The _fseeki64/_ftelli64/_mktime64 variants are needed for correctness on Windows. cfg_attr link_name redirects the symbols at link time.
MinGW uses msvcrt.dll, not ucrtbase.dll. Unconditional #[link(name = "ucrt")] breaks MinGW builds. Use cfg_attr to conditionally link ucrt only when target_env is msvc.
Combine the separate len check and index access into a single .get(pc) call. Matches PUC-Rio's idiom where pc is advanced atomically with the fetch, reducing branches in the hot loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.