Verify the artifact handoff on every push, not just at release - #22
Merged
Merged
Conversation
release.yml was the only workflow, so the build -> release artifact handoff was exercised only when a tag was cut. A regression there surfaces mid-release, after signing and notarization have already run against a bundle that was never going to work. CI now builds the bundle ad-hoc and pushes it through the same upload/download-artifact pair release.yml uses, then asserts the framework survived. The assertions are `test -L`, not `test -e`: a flattened symlink is a real directory that passes every existence check and fails only later, at codesign or at launch. Verified against a deliberately flattened bundle -- `-e`, `-d` and `-x Autoupdate` all pass on it; only `-L` catches it. Also asserts the rpath Package.swift adds by hand, since SwiftPM does not add it and the app builds, signs and notarizes without it before dying at launch on @rpath/Sparkle.framework. That one shipped once. Technique from the Don't Miss CI, which added the same round-trip check. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release.ymlwas the only workflow here, so thebuild->releaseartifact handoff only ran when a tag was cut. A regression in it surfaces mid-release, after signing and notarization have already spent their time on a bundle that was never going to work.This adds a
ci.ymlthat builds the bundle ad-hoc and pushes it through the sameupload-artifact/download-artifactpair, then checks what actually breaks.Why
test -Land nottest -e.upload-artifactflattens symlinks, andSparkle.frameworkis a versioned bundle held together by them. A flattened framework is a real directory tree. Verified against a deliberately flattened copy:Two independent detections, which is what you want for a failure whose other symptom is a notarized app that won't launch.
It also asserts the
@executable_path/../Frameworksrpath.Package.swiftadds that by hand because SwiftPM doesn't, and without it the app builds, signs, notarizes and passes every codesign check before dying at launch on@rpath/Sparkle.framework. That shipped once already.No credentials in this workflow at all, on the same reasoning that split
release.ymlinto two jobs.Round-trip technique from the Don't Miss CI, which landed the same check in
a4087bb.🤖 Generated with Claude Code