Skip to content

chore(deps-dev): JIRA-18502 Update to Coding Style 6.x - #70

Merged
owenvoke merged 1 commit into
mainfrom
JIRA-18502_coding-style
Oct 28, 2026
Merged

owenvoke merged 1 commit into
mainfrom
JIRA-18502_coding-style

Conversation

@owenvoke

Copy link
Copy Markdown
Member

This updates to Coding Style 6.x, which uses PHPStan Extension Installer.

This updates to Coding Style 6.x, which uses PHPStan Extension Installer.
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

📝 Summary

Summary by CodeRabbit

  • Refactor
    • Internal components now keep configuration and input values unchanged after initialization. Existing behavior is unchanged.
  • Chores
    • Updated development tooling and configuration. These changes do not alter end-user functionality.

The pull request updates development tooling and PHPStan configuration. It also marks constructor-held properties readonly across application classes and a test filter, and makes small test-helper and interface-documentation edits.

Changes: Tooling configuration

Layer / File(s) Summary
Update analysis and code-style tooling
composer.json, ecs.php, rector.php, phpstan.neon.dist, phpstan-baseline.neon
Composer adds strict Larastan rules and the PHPStan extension installer, and updates Larastan and coding-style constraints. ECS and Rector use fluent configuration. Rector includes the config path. PHPStan removes the coding-style Larastan include and adds four baseline ignores for callback type mismatches in src/Envy.php.

Readonly constructor properties

Layer / File(s) Summary
Mark stored properties readonly
src/Actions/*, src/Envy.php, src/Support/*, src/Contracts/Actions/UpdatesEnvironmentFile.php, tests/Concerns/ResetsTestFiles.php, tests/Unit/Actions/FilterEnvironmentCallsTest.php
Constructor-held properties in actions, Envy, support classes, visitors, and a test filter are now readonly. The test helper no longer binds the caught exception, and the interface’s $filePath parameter documentation is removed.

Priority: Not assessed

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Other

Suggested reviewers: lukeraymonddowning

Merge Risk: Moderate · up to 41dc0

The tooling update and readonly property changes are low risk at runtime. The PHPStan baseline entry for sortBy may not match under Laravel 12, which could fail static analysis in CI for that matrix entry. Fix or confirm this before merging.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@owenvoke
owenvoke merged commit 58285bd into main Oct 28, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant