Skip to content

List the wrong release first in release lookup specs #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AliSoftware merged 1 commit into from
Aug 3, 2026
Merged

List the wrong release first in release lookup specs #764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions spec/github_helper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,9 @@ def create_release(is_draft:, assets: [], name: nil)
stale_release = sawyer_resource_stub(id: 1, url: 'stale-api-url', html_url: 'stale-html-url', tag_name: test_version, draft: true)
latest_release = sawyer_resource_stub(id: 2, url: 'latest-api-url', html_url: 'latest-html-url', tag_name: test_version, draft: true)

allow(client).to receive(:releases).with(test_repo).and_return([latest_release, stale_release])
# The stale release comes first, so that a lookup relying on the order the API happens to return the releases in
# would pick the wrong one.
allow(client).to receive(:releases).with(test_repo).and_return([stale_release, latest_release])
expect(client).not_to receive(:release_for_tag)
allow(client).to receive(:release_assets).with(latest_release.url).and_return([])

Expand All @@ -757,7 +759,9 @@ def create_release(is_draft:, assets: [], name: nil)
published_release = sawyer_resource_stub(id: 351_929_162, url: 'published-api-url', html_url: 'published-html-url', tag_name: test_version, draft: false)
leftover_draft = sawyer_resource_stub(id: 352_002_205, url: 'draft-api-url', html_url: 'draft-html-url', tag_name: test_version, draft: true)

allow(client).to receive(:releases).with(test_repo).and_return([published_release, leftover_draft])
# The leftover draft comes first, so that a lookup relying on the order the API happens to return the releases in
# would pick the wrong one.
allow(client).to receive(:releases).with(test_repo).and_return([leftover_draft, published_release])
allow(client).to receive(:release_assets).with(published_release.url).and_return([])

with_tmp_file(named: 'test-app.zip') do |file_path|
Expand Down