Conversation
XPath text extraction (e.g. normalize-space() over a content container) returns a node's full string-value, which includes descendant text nodes inside nested <script> and <style> elements. Sites that inject JSON-LD or other markup via client-side JS directly into a content container (as seen on maybelline.com.tr, where BreadcrumbList/HowTo/Article JSON-LD ended up inside schema:articleBody) leak that markup into any graph-sync mapping that extracts text from the container. HtmlConverter already strips comment and processing-instruction nodes before XPath mappings run; extend the same pass to remove <script> and <style> elements so their text never reaches XPath-based extraction.
Contributor
|
Hey Rastko, the
seems generic enough that this change shouldn’t necessarily be applied there. It seems to me that it should be the responsibility of the consumer of that XHTML to eventually strip/skip undesired tags. What’s your reading on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XPath text extraction (e.g. normalize-space() over a content container) returns a node's full string-value, which includes descendant text nodes inside nested <script> and <style> elements. Sites that inject JSON-LD or other markup via client-side JS directly into a content container (as seen on maybelline.com.tr, where BreadcrumbList/HowTo/Article JSON-LD ended up inside schema:articleBody) leak that markup into any graph-sync mapping that extracts text from the container.
HtmlConverter already strips comment and processing-instruction nodes before XPath mappings run; extend the same pass to remove <script> and <style> elements so their text never reaches XPath-based extraction.